but wouldn't they expire after a period of time if you close your continental one pass??
1) OnePass miles
currently have no expiration date (this will change, see below).
2) Even after the new expiration policy takes effect, you don't need a credit card to keep your miles. Your miles won't expire so long as you have activity in the account (see T&Cs for a better explanation).
From CO's page:
Mileage Expiration
Miles currently have no expiry date; however, Continental Airlines reserves the right to impose expiry limits or terminate the OnePass program, thus terminating your ability to claim rewards. The OnePass program will formally end on December 31, 2011, followed by a wind-down period during the first quarter of 2012. Following the wind-down period, your OnePass award miles will be replaced with an equivalent grant of Mileage Plus reward miles. At that point, the Mileage Plus 18-month expiration policy will apply.
Inactive Membership
If no mileage is deposited in your account for 18 consecutive months, your membership may be cancelled, and your miles may be forfeited. To keep your account active, you can earn mileage with a variety of airline, non-travel and shopping partners. Please visit the Earn Miles section of this site for a full list of earnings partners.