We get very little if anything in return from other countries. Also remember there is a downside for our aid/support of Israel. It fuels the hate towards us in the Arab world but that is the price we pay.
My beef is not with the aid but them apparently asking for more when our president already committed to replenishing the Iron Dome. It is like an ungrateful stepchild.
2 points. First, our aid to Israel does absolutely nothing to increase the hate against the US. Either they hate us and our values, or they don't. Contrary to the perception on the street here, the Arab world has more concerns than Israel. Second, asking for more doesn't mean they're ungrateful. We can say no and our relationship won't change. They made a request, and we have to decide for ourselves if we think it's worth it.
ETA: I think the issue here is that you (and most Americans) look at Israel as a step-child, a one-way relationship where Israel is fully dependant on the generosity of the US with little-to-no return. We only see headlines of the money and arms going out, but we don't see what comes back. How many attacks against US interests has Israel prevented? How much have we benefited from their tech and science? None of that gets publicized, and that's probably in our best interest. There's a reason governmental support for Israel is bipartisan (in the committees and departments that matter), and it's not because of AIPAC.