There were successes, but a real victory means a lasting peace and security for your citizens. I's not like we're talking a victory and then 3 decades later a new threat emerges. These are all succeeding threats that emerge immediately from Israel's caving to pressure and not finishing the job.
The problem is that all this "should have finished the job" rhetoric totally ignores the geopolitical realities that did (and still do!) hamstring what IL is able to do.
If you get an arms embargo against the state, if you get the UN and other international actors to turn IL into a pariah state ala Saddam's Iraq or North Korea, or international boots on the ground enforcing an internationally imposed solution to the "palestinian issue" It don't do too much good that you whipped the hide of some overgrown arab cowboys playing with rockets and showed them who's boss.
IL had no choice in 1956, heck the IL allies UK and France were humiliated by the US telling them "Put away the guns boys, it's not playtime now". But it was a win. The Israeli objectives were achieved.
1967 the IDF was on the outskirts of both Damascus and Cairo... but was stopped by the world. But it was a win. The Israeli objectives were achieved.
Shalom Lagalil achieved the Israeli objectives. The fact that after many years of international and leftie domestic pressure it withdrew from SL, does not negate that. It only shows,
again, that IL cannot rely on international law and forces to secure SL. The same for the 2nd Lebanon War.