When I dated, (erev sukkes 10 years ago) I told my wife about my yeshiva Egypt trips. She asked me if it was safe and I said no issue at all. A day later they blew up the hilton taba :-) anyway, I took her to sharm el shaik a few weeks after we were married and we had a blast
I was there 4 times and as long as you stick to the resorts I would say you are fine today as well.
As a bochur I did a day trip driving the entire Sinai. We hired a cab driver for a day and did taba,dahab, sharm, har sinai and some other stuff... yes, the stone with the "sne" does exist. I took them home. We drove with a beduin cab driver with mbd blasting the entire day. He even took us to his family house for some tea
Is it safe today. Yes, but you do have a risk involved even if it's small. There are people out there, that want to harm you. More then in Petra or dubai